This repository has been archived by the owner on Jan 30, 2020. It is now read-only.
Removes default dependency to Zend\StdLib #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| /** | ||
| * Setup autoloading | ||
| */ | ||
| require __DIR__ . '/../vendor/autoload.php'; | ||
|
|
||
| /** | ||
| * Setting the Zend\StdLib/ErrorHandler as default ErrorHandler | ||
| */ | ||
| Zend\Ldap\ErrorHandler::setErrorHandler(new ZendTest\Ldap\ErrorHandler()); |
There was a problem hiding this comment.
As the default ErrorHandler does nothing at all but the tests seem to depend on error-suppression I've added that one to get the tests running under the same conditions as before. I was thinking of adding that line to src/Ldap.php (at the very end) so that that's set as default error handler and users can overwrite that with their own implementation. On the other hand that would mean that the dependency to Zend\StdLib\ErrorHandler would not be eliminated.
|
Looks nice! |
| }, | ||
| "require-dev": { | ||
| "zendframework/zend-config": "~2.5", | ||
| "zendframework/zend-eventmanager": "~2.5", | ||
| "fabpot/php-cs-fixer": "1.7.*", | ||
| "phpunit/PHPUnit": "~4.0" | ||
| "phpunit/PHPUnit": "~5.0", |
There was a problem hiding this comment.
you can use "phpunit/phpunit": "~4.0|~5.0" then the dependency of php >=5.6 will use phpunit 5, and for php 5.5 will still uses phpunit 4
heiglandreas
changed the title
This was referenced Jan 14, 2016
|
👍 |
This commit removes the default dependency to the ```\Zend\StdLib\ErrorHandler``` by replacing it with a ```\Zend\Ldap\ErrorHandler``` that delegates the error handling to an injectable ErrorHandler. That way the tests can use ```\Zend\StdLib\ErrorHandler``` and silence errors during the tests whereas in a live environment no error-suppression is used by default. Other ErrorHandlers can be used by creating a class that implements ```\Zend\Ldap\ErrorHandlerInterface``` and injecting an instance of that class as ErrorHandler using ```\Zend\Ldap\ErrorHandler::setErrorHandler()```
This commit adds some space and newlines
heiglandreas
force-pushed
the
feature/removeExternalDependencies
branch
from
b6829cb
to
81bf78b
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit removes the default dependency to the
\Zend\StdLib\ErrorHandlerby replacing it with a\Zend\Ldap\ErrorHandlerthat delegates the error handling to an injectable ErrorHandler.That way the tests can use
\Zend\StdLib\ErrorHandlerand silence errors during the tests whereas in a live environment no error-suppression is used by default.Other ErrorHandlers can be used by creating a class that implements
\Zend\Ldap\ErrorHandlerInterfaceand injecting an instance of that class as ErrorHandler using\Zend\Ldap\ErrorHandler::setErrorHandler()The main aim would be to get rid of external dependencies to make the component as independent as possible and allow a more widespread usage.
This has been influenced by zendframework/zendframework#7497 and symfony/symfony-docs#5756